[gnome-software/gnome-3-26] app row: Change the default for set_colorful to false
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/gnome-3-26] app row: Change the default for set_colorful to false
- Date: Fri, 9 Mar 2018 07:47:43 +0000 (UTC)
commit 87328cdea1a1a4cb72f1e402d101f48828333677
Author: Kalev Lember <klember redhat com>
Date: Fri Feb 23 16:22:40 2018 +0100
app row: Change the default for set_colorful to false
We only have 1 page that uses it, out of 7, which makes non-colorful a
better default.
src/gs-app-row.c | 1 -
src/gs-extras-page.c | 1 +
src/gs-installed-page.c | 1 -
src/gs-moderate-page.c | 1 -
4 files changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/src/gs-app-row.c b/src/gs-app-row.c
index 54c5dea9..86b88e83 100644
--- a/src/gs-app-row.c
+++ b/src/gs-app-row.c
@@ -699,7 +699,6 @@ gs_app_row_init (GsAppRow *app_row)
gtk_widget_init_template (GTK_WIDGET (app_row));
gs_star_widget_set_icon_size (GS_STAR_WIDGET (priv->star), 12);
- priv->colorful = TRUE;
priv->settings = g_settings_new ("org.gnome.software");
g_signal_connect (priv->button, "clicked",
diff --git a/src/gs-extras-page.c b/src/gs-extras-page.c
index 101af6f8..cdd38e12 100644
--- a/src/gs-extras-page.c
+++ b/src/gs-extras-page.c
@@ -292,6 +292,7 @@ gs_extras_page_add_app (GsExtrasPage *self, GsApp *app, SearchData *search_data)
}
app_row = gs_app_row_new (app);
+ gs_app_row_set_colorful (GS_APP_ROW (app_row), TRUE);
gs_app_row_set_show_buttons (GS_APP_ROW (app_row), TRUE);
g_object_set_data_full (G_OBJECT (app_row), "missing-title", g_strdup (search_data->title), g_free);
diff --git a/src/gs-installed-page.c b/src/gs-installed-page.c
index 2c8a08eb..520cc753 100644
--- a/src/gs-installed-page.c
+++ b/src/gs-installed-page.c
@@ -186,7 +186,6 @@ gs_installed_page_add_app (GsInstalledPage *self, GsAppList *list, GsApp *app)
GtkWidget *app_row;
app_row = gs_app_row_new (app);
- gs_app_row_set_colorful (GS_APP_ROW (app_row), FALSE);
gs_app_row_set_show_folders (GS_APP_ROW (app_row), TRUE);
gs_app_row_set_show_buttons (GS_APP_ROW (app_row), TRUE);
if (!gs_app_has_quirk (app, AS_APP_QUIRK_PROVENANCE) ||
diff --git a/src/gs-moderate-page.c b/src/gs-moderate-page.c
index 0149a5ef..9e825778 100644
--- a/src/gs-moderate-page.c
+++ b/src/gs-moderate-page.c
@@ -142,7 +142,6 @@ gs_moderate_page_add_app (GsModeratePage *self, GsApp *app)
/* add top level app */
app_row = gs_app_row_new (app);
- gs_app_row_set_colorful (GS_APP_ROW (app_row), FALSE);
gs_app_row_set_show_buttons (GS_APP_ROW (app_row), TRUE);
gtk_container_add (GTK_CONTAINER (self->list_box_install), app_row);
gs_app_row_set_size_groups (GS_APP_ROW (app_row),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]