[gimp] Bug 794023 - Bad/Double free bugs found by scan-build.
- From: Jehan Pagès <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Bug 794023 - Bad/Double free bugs found by scan-build.
- Date: Sat, 3 Mar 2018 15:44:02 +0000 (UTC)
commit c9d9b5535bc5f67016c973dfcbf3d2cb3b3606c8
Author: Jehan <jehan girinstud io>
Date: Sat Mar 3 16:41:43 2018 +0100
Bug 794023 - Bad/Double free bugs found by scan-build.
In case of error in gimp_prop_eval_parse_reference(), we were obviously
freeing the string which had just been allocated by g_strdup(), not the
pointer to this string.
Thanks to Massimo for raising this issue.
app/propgui/gimppropgui-eval.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/app/propgui/gimppropgui-eval.c b/app/propgui/gimppropgui-eval.c
index ca5d843..d182a86 100644
--- a/app/propgui/gimppropgui-eval.c
+++ b/app/propgui/gimppropgui-eval.c
@@ -882,7 +882,7 @@ gimp_prop_eval_parse_reference (GObject *config,
if (*error)
{
- g_free (ref_key);
+ g_free (*ref_key);
return FALSE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]