[devhelp] Sidebar: add FIXME comment
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [devhelp] Sidebar: add FIXME comment
- Date: Thu, 4 Jan 2018 20:17:32 +0000 (UTC)
commit 91b85abf1d79d4aa96f54a03defa10a3f07d3e18
Author: Sébastien Wilmet <swilmet gnome org>
Date: Thu Jan 4 21:11:01 2018 +0100
Sidebar: add FIXME comment
src/dh-sidebar.c | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
---
diff --git a/src/dh-sidebar.c b/src/dh-sidebar.c
index 6d245bc..a768165 100644
--- a/src/dh-sidebar.c
+++ b/src/dh-sidebar.c
@@ -328,7 +328,19 @@ entry_key_press_event_cb (GtkEntry *entry,
DhLink *link;
gchar *name;
- /* Get the first entry found. */
+ /* Get the first entry found.
+ *
+ * FIXME: is it really useful to do that? If there is an exact
+ * match it already gets selected, so it seems that the feature
+ * here just selects a random symbol (the one that appears to be
+ * the first in the list).
+ * I've never used this feature -- swilmet.
+ * This has been implemented in
+ * commit 455440a93d1b55d5a1e53ecabb2ee33093eec965
+ * and https://bugzilla.gnome.org/show_bug.cgi?id=114558
+ * but maybe at that time the search didn't jump to the exact
+ * match if there was one.
+ */
if (gtk_widget_is_visible (GTK_WIDGET (priv->hitlist_view)) &&
gtk_tree_model_get_iter_first (GTK_TREE_MODEL (priv->hitlist_model), &iter)) {
gtk_tree_model_get (GTK_TREE_MODEL (priv->hitlist_model),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]