[devhelp] Sidebar: better use GtkEditable API



commit d794b55e9012f8c57d18e3839119e8f00e7fc27d
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Thu Jan 4 21:10:05 2018 +0100

    Sidebar: better use GtkEditable API
    
    For gtk_editable_select_region() a negative start_pos is not specified
    in the API. It's better to rely only on what is documented.

 src/dh-sidebar.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/dh-sidebar.c b/src/dh-sidebar.c
index 26da63c..6d245bc 100644
--- a/src/dh-sidebar.c
+++ b/src/dh-sidebar.c
@@ -315,8 +315,8 @@ entry_key_press_event_cb (GtkEntry    *entry,
                         if (gtk_widget_is_visible (GTK_WIDGET (priv->hitlist_view)))
                                 gtk_widget_grab_focus (GTK_WIDGET (priv->hitlist_view));
                 } else {
+                        gtk_editable_select_region (GTK_EDITABLE (entry), 0, 0);
                         gtk_editable_set_position (GTK_EDITABLE (entry), -1);
-                        gtk_editable_select_region (GTK_EDITABLE (entry), -1, -1);
                 }
 
                 return GDK_EVENT_STOP;
@@ -340,8 +340,8 @@ entry_key_press_event_cb (GtkEntry    *entry,
                         gtk_entry_set_text (entry, name);
                         g_free (name);
 
+                        gtk_editable_select_region (GTK_EDITABLE (entry), 0, 0);
                         gtk_editable_set_position (GTK_EDITABLE (entry), -1);
-                        gtk_editable_select_region (GTK_EDITABLE (entry), -1, -1);
 
                         g_signal_emit (sidebar, signals[SIGNAL_LINK_SELECTED], 0, link);
 
@@ -648,8 +648,8 @@ dh_sidebar_set_search_string (DhSidebar   *sidebar,
         priv = dh_sidebar_get_instance_private (sidebar);
 
         gtk_entry_set_text (priv->entry, str);
+        gtk_editable_select_region (GTK_EDITABLE (priv->entry), 0, 0);
         gtk_editable_set_position (GTK_EDITABLE (priv->entry), -1);
-        gtk_editable_select_region (GTK_EDITABLE (priv->entry), -1, -1);
 
         /* If the GtkEntry text was already equal to @str, the
          * GtkEditable::changed signal was not emitted, so force to emit it to


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]