[gnome-builder] runtimes: avoid signal emission when unloading



commit 9086e1c2986559a09b3ef4260b87dfe6edf892e7
Author: Christian Hergert <chergert redhat com>
Date:   Sun Feb 18 14:31:35 2018 -0800

    runtimes: avoid signal emission when unloading
    
    If we're unloading the context, we don't want to spam listeners about the
    changes to the underlying system. Just rely on widgetry cleanup.

 src/libide/runtimes/ide-runtime-manager.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/libide/runtimes/ide-runtime-manager.c b/src/libide/runtimes/ide-runtime-manager.c
index 992f7b70f..c08d167a1 100644
--- a/src/libide/runtimes/ide-runtime-manager.c
+++ b/src/libide/runtimes/ide-runtime-manager.c
@@ -214,9 +214,6 @@ ide_runtime_manager_remove (IdeRuntimeManager *self,
   g_return_if_fail (IDE_IS_RUNTIME_MANAGER (self));
   g_return_if_fail (IDE_IS_RUNTIME (runtime));
 
-  if (self->unloading)
-    return;
-
   for (guint i = 0; i < self->runtimes->len; i++)
     {
       IdeRuntime *item = g_ptr_array_index (self->runtimes, i);
@@ -224,7 +221,8 @@ ide_runtime_manager_remove (IdeRuntimeManager *self,
       if (runtime == item)
         {
           g_ptr_array_remove_index (self->runtimes, i);
-          g_list_model_items_changed (G_LIST_MODEL (self), i, 1, 0);
+          if (!ide_object_is_unloading (IDE_OBJECT (self)))
+            g_list_model_items_changed (G_LIST_MODEL (self), i, 1, 0);
           break;
         }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]