[vala/staging] Don't warn about unused internal methods which are meant to be visible on DBus
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/staging] Don't warn about unused internal methods which are meant to be visible on DBus
- Date: Tue, 13 Feb 2018 09:49:59 +0000 (UTC)
commit f15f9f8485b9591493a449aa2a28ded440e07f48
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Tue Feb 13 10:37:03 2018 +0100
Don't warn about unused internal methods which are meant to be visible on DBus
https://bugzilla.gnome.org/show_bug.cgi?id=593902
vala/valaflowanalyzer.vala | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/vala/valaflowanalyzer.vala b/vala/valaflowanalyzer.vala
index 122e58d..853eae7 100644
--- a/vala/valaflowanalyzer.vala
+++ b/vala/valaflowanalyzer.vala
@@ -170,6 +170,9 @@ public class Vala.FlowAnalyzer : CodeVisitor {
&& !(m is CreationMethod)) {
if (!m.is_private_symbol () && (context.internal_header_filename != null ||
context.use_fast_vapi)) {
// do not warn if internal member may be used outside this compilation unit
+ } else if (m.parent_symbol != null && m.parent_symbol.get_attribute ("DBus") != null
+ && m.get_attribute_bool ("DBus", "visible", true)) {
+ // do not warn if internal member is a visible DBus method
} else {
Report.warning (m.source_reference, "method `%s' never used".printf
(m.get_full_name ()));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]