[gnome-control-center/alatiera/CI-flatpak-cleanups] CI: Improve the flatpak review environments

[Jordan Petridis <jpetridis src gnome org>]

commit 399376a48420aad5e4addc008e06020224292928
Author: Jordan Petridis <jordanpetridis protonmail com>
Date:   Sat Aug 11 10:51:38 2018 +0000

    CI: Improve the flatpak review environments
    
    For more:
    
https://gitlab.gnome.org/GNOME/Initiatives/wikis/DevOps-with-Flatpak#flatpak-bundle-for-every-mr-and-commit

 .gitlab-ci.yml | 40 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7a1c23879..81d264021 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -3,6 +3,7 @@ stages:
   - build
   - test
   - manual
+  - review
   - deploy
 
 .Log files: &log_files  [./*.log, _build/meson-logs/]
@@ -144,12 +145,13 @@ pages:
 # Creates a flatpak
 ##
 flatpak:
-  stage: deploy
+  stage: build
   image: registry.gitlab.gnome.org/gnome/gnome-runtime-images/gnome:master
   artifacts:
     name: package
     paths:
     - $(pwd)/*.flatpak
+    expire_in: 2 days
 
   variables:
     APPID: "org.gnome.SettingsDevel"
@@ -188,11 +190,45 @@ flatpak:
     paths:
     - .flatpak-builder/cache
 
+review:
+  stage: review
+  dependencies:
+    - flatpak
+  
+  variables:
+    BUNDLE: "org.gnome.SettingsDevel.flatpak"
+  
+  script:
+    - echo "Generating flatpak deployment"
+  
+  artifacts:
+    paths:
+        - ${BUNDLE}
+    expire_in: 30 days
+ 
   environment:
     name: review/$CI_COMMIT_REF_NAME
     url: https://gitlab.gnome.org/$CI_PROJECT_PATH/-/jobs/$CI_JOB_ID/artifacts/raw/${BUNDLE}
-  when: manual
+    on_stop: stop_review
+  
+  except:
+    - tags
+    - gnome-3-.*
+    - master@GNOME/project-url
 
+stop_review:
+  stage: review
+  script:
+    - echo "Stopping flatpak deployment"
+  when: manual
+  environment:
+    name: review/$CI_COMMIT_REF_NAME
+    action: stop
+  except:
+    - tags
+    - gnome-3-.*
+    - master@GNOME/project-url
+  
 # Runs the sanitizers [address, thread, undefined, and memory].
 .sanitizer: &sanitizer
   <<: *save_build_logs