[epiphany] web-extension: Do not re-fill username field on blur event
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] web-extension: Do not re-fill username field on blur event
- Date: Sun, 10 Sep 2017 16:00:20 +0000 (UTC)
commit c66b517e663ee45c4733c8ca06b9f64987eb7050
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Sun Sep 10 10:57:01 2017 -0500
web-extension: Do not re-fill username field on blur event
I'm not sure what the benefit of this behavior is. The downside is
obvious: you can't change the username field from its autofilled value.
This is silly.
https://bugzilla.gnome.org/show_bug.cgi?id=787498
embed/web-extension/ephy-web-extension.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
---
diff --git a/embed/web-extension/ephy-web-extension.c b/embed/web-extension/ephy-web-extension.c
index 380d34c..97b60ee 100644
--- a/embed/web-extension/ephy-web-extension.c
+++ b/embed/web-extension/ephy-web-extension.c
@@ -644,15 +644,6 @@ remove_user_choices (WebKitDOMDocument *document)
}
static gboolean
-username_changed_cb (WebKitDOMNode *username_node,
- WebKitDOMEvent *dom_event,
- EphyEmbedFormAuth *form_auth)
-{
- pre_fill_form (form_auth);
- return TRUE;
-}
-
-static gboolean
user_chosen_cb (WebKitDOMNode *li,
WebKitDOMEvent *dom_event,
WebKitDOMNode *username_node)
@@ -1189,11 +1180,6 @@ web_page_form_controls_associated (WebKitWebPage *web_page,
webkit_dom_event_target_add_event_listener (WEBKIT_DOM_EVENT_TARGET (form), "submit",
G_CALLBACK (form_submitted_cb), FALSE,
web_page);
- if (username_node) {
- webkit_dom_event_target_add_event_listener (WEBKIT_DOM_EVENT_TARGET (username_node), "blur",
- G_CALLBACK (username_changed_cb), FALSE,
- form_auth);
- }
/* Plug in the user autocomplete */
origin = ephy_uri_to_security_origin (uri);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]