[recipes] Remove a workaround thats no longer needed



commit 183d73ada29942aabbd37f3007e3914e1ce526f1
Author: Matthias Clasen <mclasen redhat com>
Date:   Mon May 22 11:59:01 2017 -0400

    Remove a workaround thats no longer needed
    
    With recent GTK+, we no longer need to defer the link
    activation to an idle.

 src/gr-details-page.c |   27 +++------------------------
 1 files changed, 3 insertions(+), 24 deletions(-)
---
diff --git a/src/gr-details-page.c b/src/gr-details-page.c
index b96467f..87b1d01 100644
--- a/src/gr-details-page.c
+++ b/src/gr-details-page.c
@@ -91,8 +91,6 @@ struct _GrDetailsPage
         GtkWidget *error_revealer;
 
         guint save_timeout;
-
-        char *uri;
 };
 
 G_DEFINE_TYPE (GrDetailsPage, gr_details_page, GTK_TYPE_BOX)
@@ -238,7 +236,6 @@ details_page_finalize (GObject *object)
         g_clear_object (&self->ingredients);
         g_clear_object (&self->printer);
         g_clear_object (&self->exporter);
-        g_clear_pointer (&self->uri, g_free);
         g_clear_pointer (&self->ing_text, g_free);
 
         G_OBJECT_CLASS (gr_details_page_parent_class)->finalize (object);
@@ -292,14 +289,10 @@ schedule_save (GtkTextBuffer *buffer, GrDetailsPage *page)
 }
 
 static gboolean
-activate_uri_at_idle (gpointer data)
+activate_link (GtkLabel      *label,
+               const char    *uri,
+               GrDetailsPage *page)
 {
-        GrDetailsPage *page = data;
-        g_autofree char *uri = NULL;
-
-        uri = page->uri;
-        page->uri = NULL;
-
         if (g_str_has_prefix (uri, "image:")) {
                 int idx;
 
@@ -328,20 +321,6 @@ activate_uri_at_idle (gpointer data)
                 }
         }
 
-        return G_SOURCE_REMOVE;
-}
-
-static gboolean
-activate_link (GtkLabel      *label,
-               const char    *uri,
-               GrDetailsPage *page)
-{
-        g_free (page->uri);
-        page->uri = g_strdup (uri);
-
-        // FIXME: We can avoid the idle with GTK+ 3.22.6 or newer
-        g_idle_add (activate_uri_at_idle, page);
-
         return TRUE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]