[gnome-software/gnome-3-22] Do not show the origin comment in the details page
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/gnome-3-22] Do not show the origin comment in the details page
- Date: Tue, 2 May 2017 07:32:39 +0000 (UTC)
commit 4a147f3343acf6f608fad37606e72402b6107489
Author: Richard Hughes <richard hughsie com>
Date: Tue May 2 08:29:53 2017 +0100
Do not show the origin comment in the details page
This can easily be spoofed with a malicious flatpakrepo or distro repo file.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=781895
src/gs-shell-details.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-shell-details.c b/src/gs-shell-details.c
index 1e3432d..9ff5eec 100644
--- a/src/gs-shell-details.c
+++ b/src/gs-shell-details.c
@@ -886,9 +886,7 @@ gs_shell_details_refresh_all (GsShellDetails *self)
}
/* set the origin */
- tmp = gs_app_get_origin_ui (self->app);
- if (tmp == NULL)
- tmp = gs_app_get_origin_hostname (self->app);
+ tmp = gs_app_get_origin_hostname (self->app);
if (tmp == NULL)
tmp = gs_app_get_origin (self->app);
if (tmp == NULL || tmp[0] == '\0') {
@@ -1456,7 +1454,7 @@ gs_shell_details_set_local_file (GsShellDetails *self, GFile *file)
GS_PLUGIN_REFINE_FLAGS_REQUIRE_SIZE |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY |
- GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI |
+ GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
@@ -1480,7 +1478,7 @@ gs_shell_details_load (GsShellDetails *self)
GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
- GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI |
+ GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL |
GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]