[gimp] app: base the stroke width defaults on the y resolution defaults.



commit 758836e49b264179524e0f95c668d219f20463d1
Author: Jehan <jehan girinstud io>
Date:   Thu Mar 23 15:44:21 2017 +0100

    app: base the stroke width defaults on the y resolution defaults.
    
    Commit 4beff2f was basing it on the screen y PPI but that is not really
    consistent or logical actually. Since the actual stroke dialog uses the
    y resolution of the current image, it makes sense that the generic
    stroke defaults in the preferences should use the y resolution of the
    default image.

 app/dialogs/preferences-dialog.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/app/dialogs/preferences-dialog.c b/app/dialogs/preferences-dialog.c
index dd1e3e1..e496be9 100644
--- a/app/dialogs/preferences-dialog.c
+++ b/app/dialogs/preferences-dialog.c
@@ -2122,10 +2122,13 @@ prefs_dialog_new (Gimp       *gimp,
 
   /* The stroke line width physical values could be based on either the
    * x or y resolution, some average, or whatever which makes a bit of
-   * sense. There is no perfect answer. So let's just use whatever.
+   * sense. There is no perfect answer. The actual stroke dialog though
+   * uses the y resolution on the opened image. So using the y resolution
+   * of the default image seems like the best compromise in the preferences.
    */
   table = gimp_stroke_editor_new (GIMP_DIALOG_CONFIG (object)->stroke_options,
-                                  yres, FALSE);
+                                  gimp_template_get_resolution_y (core_config->default_image),
+                                  FALSE);
   gtk_box_pack_start (GTK_BOX (vbox2), table, FALSE, FALSE, 0);
   gtk_widget_show (table);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]