[gnome-builder] flatpak: ensure we return failure



commit 4a9ba5e08c35441f99ac95d134b5c70c9623c69b
Author: Christian Hergert <chergert redhat com>
Date:   Tue Mar 7 01:37:44 2017 -0800

    flatpak: ensure we return failure
    
    If we fail to locate the SDK, ensure that we return an error to the task.

 plugins/flatpak/gbp-flatpak-application-addin.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/plugins/flatpak/gbp-flatpak-application-addin.c b/plugins/flatpak/gbp-flatpak-application-addin.c
index 5627e48..0b60994 100644
--- a/plugins/flatpak/gbp-flatpak-application-addin.c
+++ b/plugins/flatpak/gbp-flatpak-application-addin.c
@@ -758,6 +758,9 @@ gbp_flatpak_application_addin_locate_sdk_worker (GTask        *task,
   g_assert (locate->installations != NULL);
   g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
 
+  IDE_TRACE_MSG ("Locating SDK for %s/%s/%s",
+                 locate->id, locate->arch, locate->branch);
+
   /*
    * Look through all of our remote refs and see if we find a match for
    * the runtime for which we need to locate the SDK. Afterwards, we need
@@ -860,6 +863,11 @@ gbp_flatpak_application_addin_locate_sdk_worker (GTask        *task,
         }
     }
 
+  g_task_return_new_error (task,
+                           G_IO_ERROR,
+                           G_IO_ERROR_NOT_FOUND,
+                           "Failed to locate corresponding SDK");
+
   IDE_EXIT;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]