[glib] Do not mix declarations and statements



commit ea365530d2ddf88fec914a12899f1ece6d9962ba
Author: Emmanuele Bassi <ebassi gnome org>
Date:   Tue Jul 11 12:15:44 2017 +0100

    Do not mix declarations and statements
    
    Projects using glib-genmarshal may still wish to support C89.

 gobject/glib-genmarshal.in |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/gobject/glib-genmarshal.in b/gobject/glib-genmarshal.in
index ca78e1a..fd10870 100755
--- a/gobject/glib-genmarshal.in
+++ b/gobject/glib-genmarshal.in
@@ -650,7 +650,6 @@ def generate_body(retval, params, prefix, va_marshal=False):
 
     if retval_setter:
         body += ['  {} v_return;'.format(OUT_ARGS[retval]['ctype'])]
-        body += ['  g_return_if_fail (return_value != NULL);']
 
     if va_marshal:
         for idx, arg in enumerate(get_args):
@@ -680,7 +679,14 @@ def generate_body(retval, params, prefix, va_marshal=False):
                         body += [BOX_UNTYPED_STR.format(idx=idx, box_func=box_func)]
 
             body += ['  va_end (args_copy);']
-    else:
+
+    body += ['']
+
+    # Preconditions check
+    if retval_setter:
+        body += ['  g_return_if_fail (return_value != NULL);']
+
+    if not va_marshal:
         body += ['  g_return_if_fail (n_param_values == {:d});'.format(len(get_args) + 1)]
 
     body += ['']


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]