[polari] serverRoomManager: Fix runtime warning
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] serverRoomManager: Fix runtime warning
- Date: Mon, 20 Feb 2017 16:59:44 +0000 (UTC)
commit 00700835467bc1e4c93b273e637ed15da8aeb2fd
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Feb 20 16:45:04 2017 +0100
serverRoomManager: Fix runtime warning
The callback to the GtkCellRendererToggle::toggled signal used different
names for the 'path' parameter in parameter list and function block,
whoops. It turns out that this error made the checkbox work correctly,
as we already handle the GtkTreeView::row-activated signal, which is
also emitted, to toggle the checked setting. Toggling a boolean twice
is clearly not what we want, so just remove the faulty signal handler.
src/serverRoomManager.js | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/src/serverRoomManager.js b/src/serverRoomManager.js
index 145cc1b..9176a0e 100644
--- a/src/serverRoomManager.js
+++ b/src/serverRoomManager.js
@@ -155,9 +155,6 @@ const ServerRoomList = new Lang.Class({
this._list.append_column(column);
renderer = new Gtk.CellRendererToggle();
- renderer.connect('toggled', (cell, pathStr) => {
- this._toggleChecked(Gtk.TreePath.new_from_string(pathString));
- });
column.pack_start(renderer, false);
column.add_attribute(renderer, 'active', RoomListColumn.CHECKED);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]