[gdm] manager: fix dangling pointer free



commit 42ae1307ed33829bfd29ac9a8c87049a25e46f09
Author: Ray Strode <rstrode redhat com>
Date:   Wed Aug 23 09:26:11 2017 -0400

    manager: fix dangling pointer free
    
    When reauthenticating, we can crash if no login screen
    is running on the seat (for instance, when building
    with --disable-user-display-server, and not user
    switching).  The crash is due to a dangling
    pointer.
    
    This commit fixes that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786656

 daemon/gdm-manager.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c
index 148de5a..b8e8d54 100644
--- a/daemon/gdm-manager.c
+++ b/daemon/gdm-manager.c
@@ -2048,8 +2048,8 @@ on_session_reauthenticated (GdmSession *session,
                                 gdm_display_unmanage (display);
                                 gdm_display_finish (display);
                         }
+                        g_free (session_id);
                 }
-                g_free (session_id);
         }
 
         /* There should already be a session running, so jump to its


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]