[tracker] libtracker-data: Drop redundant error path



commit bca850564490916795df3897ad12b4738ba89607
Author: Philip Withnall <withnall endlessm com>
Date:   Fri Aug 4 13:11:14 2017 +0100

    libtracker-data: Drop redundant error path
    
    prepare_for_exec() defines iface as non-nullable, so Vala automatically
    (and correctly) inserts a g_return_val_if_fail (iface != NULL) for us.
    That makes this error path redundant and unreachable.
    
    Spotted by Coverity (CID #1452447).
    
    Signed-off-by: Philip Withnall <withnall endlessm com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=785809

 src/libtracker-data/tracker-sparql-query.vala |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/src/libtracker-data/tracker-sparql-query.vala b/src/libtracker-data/tracker-sparql-query.vala
index 97e29f8..32d31ef 100644
--- a/src/libtracker-data/tracker-sparql-query.vala
+++ b/src/libtracker-data/tracker-sparql-query.vala
@@ -509,10 +509,6 @@ public class Tracker.Sparql.Query : Object {
        }
 
        DBStatement prepare_for_exec (DBInterface iface, string sql) throws DBInterfaceError, Sparql.Error, 
DateError {
-               if (iface == null) {
-                       throw new DBInterfaceError.OPEN_ERROR ("Error opening database");
-               }
-
                var stmt = iface.create_statement (no_cache ? DBStatementCacheType.NONE : 
DBStatementCacheType.SELECT, "%s", sql);
 
                // set literals specified in query


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]