[epiphany] main: remove startup error dialog
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] main: remove startup error dialog
- Date: Sun, 30 Oct 2016 01:32:19 +0000 (UTC)
commit d7237ad2b1e1f28d0cddd6c1d666186f5221aae6
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sat Oct 29 20:30:53 2016 -0500
main: remove startup error dialog
This should never ever be shown. I've never ever seen it shown. We
should always always trigger the distro bug reporting tool if we fail to
start. That means we'd better crash.
src/ephy-main.c | 27 ++-------------------------
1 files changed, 2 insertions(+), 25 deletions(-)
---
diff --git a/src/ephy-main.c b/src/ephy-main.c
index 3310703..65d97ed 100644
--- a/src/ephy-main.c
+++ b/src/ephy-main.c
@@ -141,27 +141,6 @@ get_startup_id (void)
return retval;
}
-static void
-show_error_message (GError **error)
-{
- GtkWidget *dialog;
-
- /* FIXME better texts!!! */
- dialog = gtk_message_dialog_new (NULL,
- GTK_DIALOG_MODAL,
- GTK_MESSAGE_ERROR,
- GTK_BUTTONS_CLOSE,
- _("Could not start Web"));
- gtk_message_dialog_format_secondary_text
- (GTK_MESSAGE_DIALOG (dialog),
- _("Startup failed because of the following error:\n%s"),
- (*error)->message);
-
- g_clear_error (error);
-
- gtk_dialog_run (GTK_DIALOG (dialog));
-}
-
static EphyStartupFlags
get_startup_flags (void)
{
@@ -332,10 +311,8 @@ main (int argc,
if (profile_directory && !incognito_mode)
flags |= EPHY_FILE_HELPERS_KEEP_DIR;
- if (!ephy_file_helpers_init (profile_directory, flags,
- &error)) {
- show_error_message (&error);
- exit (1);
+ if (!ephy_file_helpers_init (profile_directory, flags, &error)) {
+ g_error ("Fatal initialization error: %s", error->message);
}
/* Run the migration in all cases, except when running a private
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]