[gnome-shell] portalHelper: Use a constant for the host name and URI
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] portalHelper: Use a constant for the host name and URI
- Date: Wed, 23 Nov 2016 20:38:49 +0000 (UTC)
commit c4a07fad835f668867fa292cdaae5a48d33a0183
Author: Debarshi Ray <debarshir gnome org>
Date: Mon Oct 24 16:58:24 2016 +0200
portalHelper: Use a constant for the host name and URI
https://bugzilla.gnome.org/show_bug.cgi?id=769940
js/portalHelper/main.js | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/js/portalHelper/main.js b/js/portalHelper/main.js
index 75daf66..427fd85 100644
--- a/js/portalHelper/main.js
+++ b/js/portalHelper/main.js
@@ -20,6 +20,8 @@ const PortalHelperResult = {
};
const INACTIVITY_TIMEOUT = 30000; //ms
+const CONNECTIVITY_CHECK_HOST = 'nmcheck.gnome.org';
+const CONNECTIVITY_CHECK_URI = 'http://' + CONNECTIVITY_CHECK_HOST;
const CONNECTIVITY_RECHECK_RATELIMIT_TIMEOUT = 30 * GLib.USEC_PER_SEC;
const HelperDBusInterface = '<node> \
@@ -50,7 +52,7 @@ const PortalWindow = new Lang.Class({
this.parent({ application: application });
if (!url) {
- url = 'http://nmcheck.gnome.org';
+ url = CONNECTIVITY_CHECK_URI;
this._originalUrlWasGnome = true;
} else {
this._originalUrlWasGnome = false;
@@ -112,12 +114,12 @@ const PortalWindow = new Lang.Class({
let uri = new Soup.URI(request.get_uri());
if (!uri.host_equal(this._uri) && this._originalUrlWasGnome) {
- if (uri.get_host() == 'nmcheck.gnome.org' && this._everSeenRedirect) {
+ if (uri.get_host() == CONNECTIVITY_CHECK_HOST && this._everSeenRedirect) {
// Yay, we got to gnome!
decision.ignore();
this._doneCallback(PortalHelperResult.COMPLETED);
return true;
- } else if (uri.get_host() != 'nmcheck.gnome.org') {
+ } else if (uri.get_host() != CONNECTIVITY_CHECK_HOST) {
this._everSeenRedirect = true;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]