[epiphany] shell: Fix leak of bookmarks manager



commit 554bedef320f4a65be0f9441846a2b608b4ac215
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Mon Nov 21 14:04:16 2016 -0600

    shell: Fix leak of bookmarks manager
    
    Direct leak of 2362 byte(s) in 56 object(s) allocated from:
        #0 0x7fd43d6ade60 in malloc (/lib64/libasan.so.3+0xc6e60)
        #1 0x7fd4291b88f6 in g_malloc
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
        #2 0x7fd4291b8bb3 in g_malloc_n
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:331
        #3 0x7fd4291d54d8 in g_strdup
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gstrfuncs.c:363
        #4 0x7fd43d05e0af in ephy_bookmark_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmark.c:283
        #5 0x7fd43d06567d in ephy_bookmarks_manager_load_from_file
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:618
        #6 0x7fd43d06426a in ephy_bookmarks_manager_init
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:223
        #7 0x7fd42c82cc55 in g_type_create_instance
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
        #8 0x7fd42c8132aa in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
        #9 0x7fd42c8137b9 in g_object_newv
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
        #10 0x7fd42c812e5b in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
        #11 0x7fd43d0642fc in ephy_bookmarks_manager_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:245
        #12 0x7fd43d0823bf in ephy_shell_get_bookmarks_manager
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:773
        #13 0x7fd43d067ce7 in ephy_bookmarks_popover_init
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:485
        #14 0x7fd42c82cc55 in g_type_create_instance
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
        #15 0x7fd42c8132aa in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
        #16 0x7fd42c813efe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #17 0x7fd42c812eaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #18 0x7fd43d068386 in ephy_bookmarks_popover_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:559
        #19 0x7fd43d06fda0 in ephy_header_bar_constructed
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:701
        #20 0x7fd42c8133f5 in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
        #21 0x7fd42c813efe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #22 0x7fd42c812eaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #23 0x7fd43d070565 in ephy_header_bar_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:793
        #24 0x7fd43d08cf31 in setup_header_bar
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:2835
        #25 0x7fd43d08d7b2 in ephy_window_constructed
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3005
        #26 0x7fd42c8133f5 in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
        #27 0x7fd42c813efe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #28 0x7fd42c812eaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #29 0x7fd43d08e162 in ephy_window_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3134

 src/ephy-shell.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/ephy-shell.c b/src/ephy-shell.c
index 67bcf5b..38fcd0b 100644
--- a/src/ephy-shell.c
+++ b/src/ephy-shell.c
@@ -595,6 +595,7 @@ ephy_shell_dispose (GObject *object)
   g_clear_object (&shell->prefs_dialog);
   g_clear_object (&shell->network_monitor);
   g_clear_object (&shell->sync_service);
+  g_clear_object (&shell->bookmarks_manager);
 
   g_slist_free_full (shell->open_uris_idle_ids, remove_open_uris_idle_cb);
   shell->open_uris_idle_ids = NULL;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]