[epiphany] sync-crypto: Fix leak in ephy_sync_crypto_calculate_mac



commit 12cf6bb7a294e414a95a242ef50ebe1d5a0db266
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Mon Nov 21 14:02:05 2016 -0600

    sync-crypto: Fix leak in ephy_sync_crypto_calculate_mac
    
    Direct leak of 2475 byte(s) in 55 object(s) allocated from:
        #0 0x7fd43d6ade60 in malloc (/lib64/libasan.so.3+0xc6e60)
        #1 0x7fd4291b88f6 in g_malloc
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
        #2 0x7fd42917dafd in g_base64_encode
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gbase64.c:269
        #3 0x7fd43d09a8ff in ephy_sync_crypto_calculate_mac
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-crypto.c:332
        #4 0x7fd43d09c032 in ephy_sync_crypto_compute_hawk_header
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-crypto.c:698
        #5 0x7fd43d09ef4c in ephy_sync_service_send_storage_request
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:276
        #6 0x7fd43d0a0679 in ephy_sync_service_issue_storage_request
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:567
        #7 0x7fd43d0a2e6b in ephy_sync_service_release_next_storage_message
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:1047
        #8 0x7fd43d0a38ef in delete_bookmark_conditional_response_cb
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:1196
        #9 0x7fd42cec3984 in soup_session_process_queue_item
    /home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2038
        #10 0x7fd42cec3afe in async_run_queue
    /home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2077
        #11 0x7fd42cec3c25 in idle_run_queue
    /home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2111
        #12 0x7fd4291b2cf4 in g_idle_dispatch
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:5545
        #13 0x7fd4291b02b4 in g_main_dispatch
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3203
        #14 0x7fd4291b1136 in g_main_context_dispatch
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3856
        #15 0x7fd4291b131a in g_main_context_iterate
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3929
        #16 0x7fd4291b13de in g_main_context_iteration
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3990
        #17 0x7fd42cb183bd in g_application_run
    /home/mcatanzaro/src/jhbuild/checkout/glib/gio/gapplication.c:2381
        #18 0x4032ab in main
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-main.c:432
        #19 0x7fd428dba730 in __libc_start_main (/lib64/libc.so.6+0x20730)

 src/sync/ephy-sync-crypto.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/sync/ephy-sync-crypto.c b/src/sync/ephy-sync-crypto.c
index d6a3918..0e109f7 100644
--- a/src/sync/ephy-sync-crypto.c
+++ b/src/sync/ephy-sync-crypto.c
@@ -709,6 +709,7 @@ ephy_sync_crypto_compute_hawk_header (const char                *url,
 
   soup_uri_free (uri);
   g_free (hash);
+  g_free (mac);
   g_free (nonce);
   g_free (resource);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]