[rhythmbox] notification: don't update buttonless notifications when paused



commit aea7e34b246b337d1755827f036224ff0c176eaa
Author: Jonathan Matthew <jonathan d14n org>
Date:   Thu Mar 17 12:13:40 2016 +1000

    notification: don't update buttonless notifications when paused
    
    If the notification daemon doesn't support icon buttons on notifications,
    there's no reason to update notifications when playback is paused.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762203

 plugins/notification/rb-notification-plugin.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/plugins/notification/rb-notification-plugin.c b/plugins/notification/rb-notification-plugin.c
index 9a4b499..9303121 100644
--- a/plugins/notification/rb-notification-plugin.c
+++ b/plugins/notification/rb-notification-plugin.c
@@ -532,7 +532,8 @@ playing_changed_cb (RBShellPlayer *player,
                    gboolean       playing,
                    RBNotificationPlugin *plugin)
 {
-       if (playing || plugin->notification != NULL) {
+       /* only notify while not playing if there are actions in an existing notification to update */
+       if (playing || (plugin->notify_supports_icon_buttons && plugin->notification != NULL)) {
                notify_playing_entry (plugin, FALSE);
        }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]