[evolution/wip/webkit2] White-list "MagicLinks"/"MagicSmileys"/"InlineSpelling" in web_extension_properties_changed_cb()



commit 8491712eb6a54a62eac6233be5aba53e4b85dfba
Author: Milan Crha <mcrha redhat com>
Date:   Wed Mar 9 11:30:42 2016 +0100

    White-list "MagicLinks"/"MagicSmileys"/"InlineSpelling" in web_extension_properties_changed_cb()
    
    Though there might be many many many more white-listed. Having set()
    functions for the handled properties would also help, to check whether
    the value actually changed and call g_object_notify() only when it did,
    to avoid false property change notifications.

 e-util/e-html-editor-selection.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/e-util/e-html-editor-selection.c b/e-util/e-html-editor-selection.c
index 5e2d04c..ac56ab6 100644
--- a/e-util/e-html-editor-selection.c
+++ b/e-util/e-html-editor-selection.c
@@ -165,7 +165,10 @@ web_extension_properties_changed_cb (GDBusProxy *proxy,
                                selection->priv->is_monospaced = g_variant_get_boolean (value);
                                g_object_notify (G_OBJECT (selection), "monospaced");
                        } else if (g_strcmp0 (key, "HTMLMode") != 0 &&
-                                  g_strcmp0 (key, "Changed") != 0)
+                                  g_strcmp0 (key, "Changed") != 0 &&
+                                  g_strcmp0 (key, "MagicLinks") != 0 &&
+                                  g_strcmp0 (key, "MagicSmileys") != 0 &&
+                                  g_strcmp0 (key, "InlineSpelling") != 0)
                                g_warning ("UNKNOWN PROPERTY %s IN %s", key, G_STRFUNC);
                        if (camel_debug ("wex"))
                                g_print ("      %s -> %s\n", key, value_str);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]