[gnome-software/wip/rancell/reviews] Update reviews to match design



commit 06233ebc36b414697bb2b563a565e7db3d6263c8
Author: Robert Ancell <robert ancell canonical com>
Date:   Tue Feb 9 10:46:33 2016 +1300

    Update reviews to match design

 src/gs-review-row.c     |   14 +++++---------
 src/gs-review-row.ui    |   28 ++++++++++++++++++++++------
 src/gs-shell-details.ui |    3 ++-
 3 files changed, 29 insertions(+), 16 deletions(-)
---
diff --git a/src/gs-review-row.c b/src/gs-review-row.c
index 880b75a..2dea624 100644
--- a/src/gs-review-row.c
+++ b/src/gs-review-row.c
@@ -35,6 +35,7 @@ struct _GsReviewRow
        GtkWidget       *stars;
        GtkWidget       *summary_label;
        GtkWidget       *author_label;
+       GtkWidget       *date_label;
        GtkWidget       *text_label;
 };
 
@@ -49,19 +50,13 @@ gs_review_row_refresh (GsReviewRow *row)
 
        gs_star_widget_set_rating (GS_STAR_WIDGET (row->stars), gs_review_get_rating (row->review));
        reviewer = gs_review_get_reviewer (row->review);
+       gtk_label_set_text (GTK_LABEL (row->author_label), reviewer ? reviewer : "");
        date = gs_review_get_date (row->review);
-       if (reviewer != NULL && date != NULL) {
-               gchar *date_text = g_date_time_format (date, "%e %B %Y");
-               text = g_strdup_printf ("%s, %s", reviewer, date_text);
-               g_free (date_text);
-       }
-       else if (reviewer != NULL)
-               text = g_strdup (reviewer);
-       else if (date != NULL)
+       if (date != NULL)
                text = g_date_time_format (date, "%e %B %Y");
        else
                text = g_strdup ("");
-       gtk_label_set_text (GTK_LABEL (row->author_label), text);
+       gtk_label_set_text (GTK_LABEL (row->date_label), text);
        gtk_label_set_text (GTK_LABEL (row->summary_label), gs_review_get_summary (row->review));
        gtk_label_set_text (GTK_LABEL (row->text_label), gs_review_get_text (row->review));
 }
@@ -115,6 +110,7 @@ gs_review_row_class_init (GsReviewRowClass *klass)
        gtk_widget_class_bind_template_child (widget_class, GsReviewRow, stars);
        gtk_widget_class_bind_template_child (widget_class, GsReviewRow, summary_label);
        gtk_widget_class_bind_template_child (widget_class, GsReviewRow, author_label);
+       gtk_widget_class_bind_template_child (widget_class, GsReviewRow, date_label);
        gtk_widget_class_bind_template_child (widget_class, GsReviewRow, text_label);
 }
 
diff --git a/src/gs-review-row.ui b/src/gs-review-row.ui
index 44f95ca..4e281b4 100644
--- a/src/gs-review-row.ui
+++ b/src/gs-review-row.ui
@@ -6,10 +6,10 @@
     <child>
       <object class="GtkGrid" id="grid">
         <property name="visible">True</property>
-        <property name="row-spacing">12</property>
-        <property name="column-spacing">12</property>
-        <property name="margin-top">12</property>
-        <property name="margin-bottom">12</property>
+        <property name="row-spacing">5</property>
+        <property name="column-spacing">10</property>
+        <property name="margin-top">20</property>
+        <property name="margin-bottom">20</property>
         <child>
           <object class="GsStarWidget" id="stars">
             <property name="visible">True</property>
@@ -41,7 +41,7 @@
           </packing>
         </child>
         <child>
-          <object class="GtkLabel" id="author_label">
+          <object class="GtkLabel" id="date_label">
             <property name="visible">True</property>
             <property name="halign">end</property>
             <style>
@@ -56,15 +56,31 @@
           </packing>
         </child>
         <child>
+          <object class="GtkLabel" id="author_label">
+            <property name="visible">True</property>
+            <property name="halign">start</property>
+            <style>
+              <class name="dim-label"/>
+            </style>
+          </object>
+          <packing>
+            <property name="left-attach">0</property>
+            <property name="top-attach">1</property>
+            <property name="width">3</property>
+            <property name="height">1</property>
+          </packing>
+        </child>
+        <child>
           <object class="GtkLabel" id="text_label">
             <property name="visible">True</property>
             <property name="halign">start</property>
             <property name="wrap">True</property>
             <property name="xalign">0</property>
+            <property name="margin-top">10</property>
           </object>
           <packing>
             <property name="left-attach">0</property>
-            <property name="top-attach">1</property>
+            <property name="top-attach">2</property>
             <property name="width">3</property>
             <property name="height">1</property>
           </packing>
diff --git a/src/gs-shell-details.ui b/src/gs-shell-details.ui
index 317e56c..e49c105 100644
--- a/src/gs-shell-details.ui
+++ b/src/gs-shell-details.ui
@@ -1146,11 +1146,12 @@
                         <child>
                           <object class="GtkButton" id="button_review">
                             <property name="use_underline">True</property>
-                            <property name="label" translatable="yes">_Write Review</property>
+                            <property name="label" translatable="yes">_Write a Review</property>
                             <property name="can_focus">True</property>
                             <property name="receives_default">False</property>
                             <property name="halign">start</property>
                             <property name="valign">start</property>
+                            <property name="margin_bottom">20</property>
                           </object>
                         </child>
                         <child>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]