[sound-juicer] Modernize preferences dialog slightly



commit 7194ee2184c86f00c4ff5e2f28f760ff416edc94
Author: Phillip Wood <phillip wood dunelm org uk>
Date:   Thu Aug 11 11:38:39 2016 +0100

    Modernize preferences dialog slightly
    
    Changes are applied immediately so there is no sense in having any kind
    of conformation button.

 data/sound-juicer.ui |   41 +----------------------------------------
 src/sj-prefs.c       |   12 ------------
 2 files changed, 1 insertions(+), 52 deletions(-)
---
diff --git a/data/sound-juicer.ui b/data/sound-juicer.ui
index 237bae3..9a8d89e 100644
--- a/data/sound-juicer.ui
+++ b/data/sound-juicer.ui
@@ -595,6 +595,7 @@ audio-volume-medium</property>
     <property name="title" translatable="yes">Preferences</property>
     <property name="resizable">False</property>
     <property name="type_hint">dialog</property>
+    <property name="modal">True</property>
     <signal name="delete_event" handler="gtk_widget_hide_on_delete"/>
     <child internal-child="vbox">
       <object class="GtkVBox" id="dialog-vbox4">
@@ -878,45 +879,5 @@ audio-volume-medium</property>
         </child>
       </object>
     </child>
-    <child internal-child="action_area">
-      <object class="GtkHButtonBox" id="dialog-action_area4">
-        <property name="visible">True</property>
-        <property name="layout_style">end</property>
-        <child>
-          <object class="GtkButton" id="prefs_help">
-            <property name="label" translatable="yes">_Help</property>
-            <property name="use_underline">True</property>
-            <property name="visible">True</property>
-            <property name="can_focus">True</property>
-            <property name="can_default">True</property>
-            <property name="receives_default">False</property>
-          </object>
-          <packing>
-            <property name="expand">False</property>
-            <property name="fill">False</property>
-            <property name="position">0</property>
-          </packing>
-        </child>
-        <child>
-          <object class="GtkButton" id="prefs_close">
-            <property name="label" translatable="yes">_Close</property>
-            <property name="use_underline">True</property>
-            <property name="visible">True</property>
-            <property name="can_focus">True</property>
-            <property name="can_default">True</property>
-            <property name="receives_default">False</property>
-          </object>
-          <packing>
-            <property name="expand">False</property>
-            <property name="fill">False</property>
-            <property name="position">1</property>
-          </packing>
-        </child>
-      </object>
-    </child>
-    <action-widgets>
-      <action-widget response="-11">prefs_help</action-widget>
-      <action-widget response="-7">prefs_close</action-widget>
-    </action-widgets>
   </object>
 </interface>
diff --git a/src/sj-prefs.c b/src/sj-prefs.c
index 396411c..8fa4ee2 100644
--- a/src/sj-prefs.c
+++ b/src/sj-prefs.c
@@ -339,16 +339,6 @@ static void populate_pattern_combo (GtkComboBox *combo, const FilePattern *patte
   g_object_unref (store);
 }
 
-static void
-on_response (GtkDialog *dialog, gint response, gpointer user_data)
-{
-  if (response == GTK_RESPONSE_HELP) {
-    show_help (GTK_WINDOW (dialog));
-  } else {
-    gtk_widget_hide (GTK_WIDGET (dialog));
-  }
-}
-
 static void populate_profile_combo (GtkComboBox *combo)
 {
   GstEncodingTarget *target;
@@ -442,8 +432,6 @@ void show_preferences_dialog ()
     settings_changed_cb (sj_settings, SJ_SETTINGS_PATH_PATTERN, path_option);
     device_changed_cb (sj_settings, SJ_SETTINGS_DEVICE, NULL);
 
-    g_signal_connect (GTK_DIALOG (prefs_dialog), "response", G_CALLBACK (on_response), NULL);
-
     gtk_widget_show_all (prefs_dialog);
   }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]