[gnome-games] ui: Explain the "use-header-bar" workaround



commit 12af821751eba8433d401ab6b0d111795101860e
Author: Adrien Plazas <kekun plazas laposte net>
Date:   Mon Aug 15 17:32:09 2016 +0200

    ui: Explain the "use-header-bar" workaround
    
    Explain why we work around "use-header-bar" not being set by GtkBuilder
    as we now know the reason.

 data/ui/resume-dialog.ui  |    1 -
 src/ui/resume-dialog.vala |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/data/ui/resume-dialog.ui b/data/ui/resume-dialog.ui
index 5a1011b..9e110cc 100644
--- a/data/ui/resume-dialog.ui
+++ b/data/ui/resume-dialog.ui
@@ -2,7 +2,6 @@
 <interface>
   <requires lib="gtk+" version="3.16"/>
   <template class="GamesResumeDialog" parent="GtkDialog">
-    <property name="use-header-bar">1</property>
     <property name="modal">True</property>
     <property name="destroy-with-parent">True</property>
     <child internal-child="vbox">"
diff --git a/src/ui/resume-dialog.vala b/src/ui/resume-dialog.vala
index 69187e1..7d198fb 100644
--- a/src/ui/resume-dialog.vala
+++ b/src/ui/resume-dialog.vala
@@ -3,6 +3,7 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/resume-dialog.ui")]
 private class Games.ResumeDialog : Gtk.Dialog {
        construct {
-               use_header_bar = 1; // FIXME: Why doesn't this work from UI file?
+               // GtkBuilder can't set construct properties so we have to set 'use-header-bar' manually.
+               use_header_bar = 1;
        }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]