[gnome-software] trivial: Fix a crash if gs_plugin_refine_app() fails for a single plugin



commit 92b9edd814c9066fc3f4c4430cd9c42ffe5c67e9
Author: Richard Hughes <richard hughsie com>
Date:   Mon Apr 25 10:50:52 2016 +0100

    trivial: Fix a crash if gs_plugin_refine_app() fails for a single plugin
    
    We're re-using the 'ret' variable in the inner loop and not setting the value
    in the outer scope.

 src/gs-plugin-loader.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index 7934d08..8f8e3f9 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -407,6 +407,9 @@ gs_plugin_loader_run_refine (GsPluginLoader *plugin_loader,
                g_warning ("nothing adopted %s", gs_app_get_id (app));
                g_print ("%s", gs_app_to_string (app));
        }
+
+       /* success */
+       ret = TRUE;
 out:
        /* now emit all the changed signals */
        for (l = freeze_list; l != NULL; l = l->next)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]