[evolution-data-server] [IMAPx] Report message flag change only if really changed



commit b5d279c92fbe1e473923ca2046745fa6bf7a8af7
Author: Milan Crha <mcrha redhat com>
Date:   Tue Apr 5 13:45:48 2016 +0200

    [IMAPx] Report message flag change only if really changed
    
    The imapx_update_message_info_flags() could return 'changed' also
    for the CAMEL_IMAPX_MESSAGE_RECENT flag, which is not writable. It
    could cause unneeded flag change save to the server too.

 camel/providers/imapx/camel-imapx-utils.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-utils.c b/camel/providers/imapx/camel-imapx-utils.c
index 7a94724..9c2bbeb 100644
--- a/camel/providers/imapx/camel-imapx-utils.c
+++ b/camel/providers/imapx/camel-imapx-utils.c
@@ -332,16 +332,13 @@ imapx_update_message_info_flags (CamelMessageInfo *info,
                if (permanent_flags > 0)
                        server_cleared &= permanent_flags;
 
-               camel_message_info_set_flags ((
+               changed = camel_message_info_set_flags ((
                        CamelMessageInfo *) xinfo,
                        server_set | server_cleared,
                        (xinfo->info.flags | server_set) & ~server_cleared);
 
                xinfo->server_flags = server_flags;
-               xinfo->info.flags = xinfo->info.flags & ~CAMEL_MESSAGE_FOLDER_FLAGGED;
                xinfo->info.dirty = TRUE;
-
-               changed = TRUE;
        }
 
        if ((permanent_flags & CAMEL_MESSAGE_USER) != 0 && imapx_update_user_flags (info, server_user_flags))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]