[gnome-online-accounts] telepathy: Don't leak local GError after showing it



commit d36e960b147296ee998513ec77c93014f0334c36
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Wed Jul 29 12:37:55 2015 +0200

    telepathy: Don't leak local GError after showing it
    
    There are 2 occurrences in the telepathy backend where a local error is
    shown if it's set, but then it's never freed, which causes a memory
    leak.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756759

 src/goabackend/goatelepathyprovider.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/src/goabackend/goatelepathyprovider.c b/src/goabackend/goatelepathyprovider.c
index 323d733..75c410f 100644
--- a/src/goabackend/goatelepathyprovider.c
+++ b/src/goabackend/goatelepathyprovider.c
@@ -852,6 +852,7 @@ edit_parameters_clicked_cb (GtkButton *button,
 
   if (!edit_connection_parameters (data->object, data->parent, &error))
     maybe_show_error (data->parent, error, _("Cannot save the connection parameters"));
+  g_clear_error (&error);
 }
 
 static void
@@ -864,6 +865,7 @@ edit_personal_details_clicked_cb (GtkButton *button,
   if (!edit_personal_details (data->object, data->parent, &error))
     maybe_show_error (data->parent, error,
         _("Cannot save your personal information on the server"));
+  g_clear_error (&error);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]