[gnome-todo] edit-pane: don't send ::edit-finished signal needlessly



commit 2ead42d8f44ac51ed61bf6224353e093db3384b5
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Oct 27 15:17:20 2015 -0200

    edit-pane: don't send ::edit-finished signal needlessly
    
    Simply setting the task to NULL is enought to actualy
    send the GtdEditPane::edit-finished signal, thus there's
    no need to send it manually when the close button is
    clicked.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757170

 src/gtd-edit-pane.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/gtd-edit-pane.c b/src/gtd-edit-pane.c
index 57095bc..a55fe4c 100644
--- a/src/gtd-edit-pane.c
+++ b/src/gtd-edit-pane.c
@@ -110,8 +110,6 @@ gtd_edit_pane__close_button_clicked (GtkButton *button,
 
   priv = GTD_EDIT_PANE (user_data)->priv;
 
-  g_signal_emit (user_data, signals[EDIT_FINISHED], 0, priv->task);
-
   priv->should_save_task = TRUE;
   gtd_edit_pane_set_task (GTD_EDIT_PANE (user_data), NULL);
 }
@@ -425,6 +423,7 @@ gtd_edit_pane_set_task (GtdEditPane *pane,
         }
 
       priv->task = task;
+      priv->should_save_task = FALSE;
 
       if (task)
         {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]