[evolution-data-server] edataserver: Remove redundant code path from e_source_dup_secret_label()
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] edataserver: Remove redundant code path from e_source_dup_secret_label()
- Date: Mon, 11 May 2015 23:07:24 +0000 (UTC)
commit 7014b0f1d177eec329df4d8a5abaa3c4b86bd66c
Author: Philip Withnall <philip withnall collabora co uk>
Date: Sun May 10 11:17:08 2015 +0100
edataserver: Remove redundant code path from e_source_dup_secret_label()
Further up in the code, backend_name is cleared if (type == NULL),
leaving the possible options as:
1. (backend_name != NULL && type != NULL)
2. (backend_name == NULL && type != NULL)
3. (backend_name == NULL && type == NULL)
Spotted by Coverity.
CID: #1296547
https://bugzilla.gnome.org/show_bug.cgi?id=749190
libedataserver/e-source.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/libedataserver/e-source.c b/libedataserver/e-source.c
index 749aa53..ba59ced 100644
--- a/libedataserver/e-source.c
+++ b/libedataserver/e-source.c
@@ -3544,8 +3544,6 @@ e_source_dup_secret_label (ESource *source)
g_string_append_printf (secret_label, "Evolution Data Source \"%s\" (%s - %s) ",
display_name, type, backend_name);
else if (type)
g_string_append_printf (secret_label, "Evolution Data Source \"%s\" (%s)", display_name,
type);
- else if (backend_name)
- g_string_append_printf (secret_label, "Evolution Data Source \"%s\" (%s)", display_name,
backend_name);
else
g_string_append_printf (secret_label, "Evolution Data Source \"%s\"", display_name);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]