[evolution-data-server] edataserverui: Remove redundant check for an error being set
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] edataserverui: Remove redundant check for an error being set
- Date: Mon, 11 May 2015 23:07:19 +0000 (UTC)
commit 6ec46941fd43e41a3904a3474f2ad33f07eb5da3
Author: Philip Withnall <philip withnall collabora co uk>
Date: Sun May 10 11:12:33 2015 +0100
edataserverui: Remove redundant check for an error being set
There is no way this loop can have local_error set before checking
whether it is NULL. Even if the declaration of local_error was hoisted
to the parent scope, all control paths which lead to the loop being
entered would have local_error set to NULL. This might not be the
correct fix, but there is certainly a problem somewhere in this code.
Spotted by Coverity.
CID: #1296548
https://bugzilla.gnome.org/show_bug.cgi?id=749190
libedataserverui/e-credentials-prompter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libedataserverui/e-credentials-prompter.c b/libedataserverui/e-credentials-prompter.c
index 0dbd2d3..ec537c5 100644
--- a/libedataserverui/e-credentials-prompter.c
+++ b/libedataserverui/e-credentials-prompter.c
@@ -1739,7 +1739,7 @@ e_credentials_prompter_loop_prompt_sync (ECredentialsPrompter *prompter,
e_named_parameters_free (credentials);
credentials = NULL;
- if (!credentials_prompter_prompt_sync (prompter, source, is_retry, &flags, local_error ?
local_error->message : NULL,
+ if (!credentials_prompter_prompt_sync (prompter, source, is_retry, &flags, NULL,
&credentials, cancellable, error))
break;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]