[geary/wip/713150-conversations] Don't overreport "email-paths-changed"



commit 130bca52b77c80efee455d68d754cb1e53e5628d
Author: Jim Nelson <jim yorba org>
Date:   Thu Mar 19 21:16:48 2015 -0700

    Don't overreport "email-paths-changed"

 src/engine/app/app-conversation-monitor.vala |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/src/engine/app/app-conversation-monitor.vala b/src/engine/app/app-conversation-monitor.vala
index dbc6e31..c4a2547 100644
--- a/src/engine/app/app-conversation-monitor.vala
+++ b/src/engine/app/app-conversation-monitor.vala
@@ -662,14 +662,11 @@ public class Geary.App.ConversationMonitor : BaseObject {
         }
         
         // add all emails and each known path(s) to the Conversation and EmailIdentifier mapping
+        // ... don't worry if add() reports paths_changed, because we've already checked if the
+        // email was known, don't want to report "email-paths-changed" for a new add
         if (emails != null) {
-            foreach (Email email in emails) {
-                bool email_paths_changed;
-                conversation.add(email, association.known_paths[email.id], out email_paths_changed);
-                
-                if (email_paths_changed)
-                    paths_changed.set(conversation, email.id);
-            }
+            foreach (Email email in emails)
+                conversation.add(email, association.known_paths[email.id], null);
         }
         
         // if new, added, otherwise appended (if not already added)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]