[folks] tests: Switch EDS extended-info test to use a const string
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [folks] tests: Switch EDS extended-info test to use a const string
- Date: Thu, 19 Mar 2015 11:09:08 +0000 (UTC)
commit ed86baf140df2c59a46eb15d5afc588feac707b3
Author: Philip Withnall <philip withnall collabora co uk>
Date: Thu Mar 19 11:03:16 2015 +0000
tests: Switch EDS extended-info test to use a const string
Rather than a variable which is set once only.
tests/eds/extended-info.vala | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/tests/eds/extended-info.vala b/tests/eds/extended-info.vala
index 3586b62..871869c 100644
--- a/tests/eds/extended-info.vala
+++ b/tests/eds/extended-info.vala
@@ -26,7 +26,7 @@ public class ExtendedInfoTests : EdsTest.TestCase
{
private GLib.MainLoop _main_loop;
private IndividualAggregator _aggregator;
- private string _full_name;
+ private const string _FULL_NAME = "persona #1";
private bool _found_field_1;
private bool _found_field_2;
@@ -40,14 +40,13 @@ public class ExtendedInfoTests : EdsTest.TestCase
public void test_extended_info ()
{
this._main_loop = new GLib.MainLoop (null, false);
- this._full_name = "persona #1";
Gee.HashMap<string, Value?> c1 = new Gee.HashMap<string, Value?> ();
Value? v;
this.eds_backend.reset ();
v = Value (typeof (string));
- v.set_string (this._full_name);
+ v.set_string (ExtendedInfoTests._FULL_NAME);
c1.set ("full_name", (owned) v);
v = Value (typeof (string));
v.set_string ("value1");
@@ -98,8 +97,7 @@ public class ExtendedInfoTests : EdsTest.TestCase
{
assert (i != null);
- string full_name = i.full_name;
- if (full_name == this._full_name)
+ if (i.full_name == ExtendedInfoTests._FULL_NAME)
{
if (i.get_extended_field ("X-FIELD-1") != null)
this._found_field_1 = true;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]