[gnome-sudoku] Add a FIXME comment



commit 4b9c4da580b7f2152932dc2e8411d513db09908c
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Tue Mar 17 08:37:47 2015 -0500

    Add a FIXME comment

 lib/sudoku-generator.vala |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/lib/sudoku-generator.vala b/lib/sudoku-generator.vala
index fc2fcb3..1287d20 100644
--- a/lib/sudoku-generator.vala
+++ b/lib/sudoku-generator.vala
@@ -93,6 +93,11 @@ public class SudokuGenerator : Object
         }
 
         yield;
+
+        // FIXME We just check if the Cancellable was canceled after generating
+        // all the boards. This code is good, but we should also use
+        // Cancellable.connect to stop generation as early if cancelled. But see
+        // https://bugzilla.gnome.org/show_bug.cgi?id=746262
         cancellable.set_error_if_cancelled ();
         return boards;
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]