[network-manager-applet] coverity: fix two coverity reports



commit c958340dfa7b2ad7dc45d7aeb1b5ca0309c9189c
Author: Jiří Klimeš <jklimes redhat com>
Date:   Wed Jun 17 14:32:28 2015 +0200

    coverity: fix two coverity reports
    
    Defect type: DEADCODE
    network-manager-applet-1.0.3/src/connection-editor/ce-page.c:456: dead_error_line: Execution cannot reach 
this statement: "return 0;".
    
    Defect type: UNINIT
    network-manager-applet-1.0.3/src/connection-editor/ce-page.c:383: uninit_use: Using uninitialized value 
"mac".
    
    Fixes: 286168120566e4a543c91a11e8d600bbd6d9c3ca

 src/connection-editor/ce-page.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/connection-editor/ce-page.c b/src/connection-editor/ce-page.c
index abd6504..5fa8483 100644
--- a/src/connection-editor/ce-page.c
+++ b/src/connection-editor/ce-page.c
@@ -246,7 +246,7 @@ _get_device_list (CEPage *self,
        for (i = 0; i < devices->len; i++) {
                NMDevice *dev = g_ptr_array_index (devices, i);
                const char *ifname;
-               char *mac;
+               char *mac = NULL;
                char *item;
 
                if (!G_TYPE_CHECK_INSTANCE_TYPE (dev, device_type))
@@ -333,9 +333,8 @@ _device_entries_match (const char *ifname, const char *mac, const char *entry)
        else {
                if (ifname)
                        return ifname_match;
-               if (mac)
+               else
                        return mac_match;
-               return FALSE;
        }
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]