[network-manager-applet/nma-1-0] coverity: fix two coverity reports
- From: Jiří Klimeš <jklimes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet/nma-1-0] coverity: fix two coverity reports
- Date: Wed, 17 Jun 2015 12:40:08 +0000 (UTC)
commit 5bc54ef37fb547645da0ff3765356a7361c1dcd1
Author: Jiří Klimeš <jklimes redhat com>
Date: Wed Jun 17 14:32:28 2015 +0200
coverity: fix two coverity reports
Defect type: DEADCODE
network-manager-applet-1.0.3/src/connection-editor/ce-page.c:456: dead_error_line: Execution cannot reach
this statement: "return 0;".
Defect type: UNINIT
network-manager-applet-1.0.3/src/connection-editor/ce-page.c:383: uninit_use: Using uninitialized value
"mac".
Fixes: a0b0166e8942cb1df0fcdf6d28e16147adecf77b
src/connection-editor/ce-page.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/connection-editor/ce-page.c b/src/connection-editor/ce-page.c
index 4c29a3e..03d2ddf 100644
--- a/src/connection-editor/ce-page.c
+++ b/src/connection-editor/ce-page.c
@@ -364,7 +364,7 @@ _get_device_list (CEPage *self,
for (i = 0; devices && (i < devices->len); i++) {
NMDevice *dev = g_ptr_array_index (devices, i);
const char *ifname;
- char *mac;
+ char *mac = NULL;
char *item;
if (!G_TYPE_CHECK_INSTANCE_TYPE (dev, device_type))
@@ -451,9 +451,8 @@ _device_entries_match (const char *ifname, const char *mac, int type, const char
else {
if (ifname)
return ifname_match;
- if (mac)
+ else
return mac_match;
- return FALSE;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]