[gnome-dictionary] app: Remove Select All menu entry



commit 4eb580196e17bf8d900638cd5d062bc19cfcd72c
Author: Juan R. GarcĂ­a Blanco <juanrgar gmail com>
Date:   Sun Jun 7 20:56:25 2015 +0200

    app: Remove Select All menu entry
    
    The widgets used for the search entry and for showing the definition
    already handle text selection. There is no need for an entry
    menu to do this, plus we are a step closer to get rid of the Edit menu.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=334866

 src/gdict-app-menus.ui |    7 -------
 src/gdict-window.c     |   17 -----------------
 2 files changed, 0 insertions(+), 24 deletions(-)
---
diff --git a/src/gdict-app-menus.ui b/src/gdict-app-menus.ui
index 0f73337..6a6f955 100644
--- a/src/gdict-app-menus.ui
+++ b/src/gdict-app-menus.ui
@@ -63,13 +63,6 @@
       <attribute name="label" translatable="yes">_Edit</attribute>
       <section>
         <item>
-          <attribute name="label" translatable="yes">Select _All</attribute>
-          <attribute name="action">win.select-all</attribute>
-          <attribute name="accel">&lt;Primary&gt;a</attribute>
-        </item>
-      </section>
-      <section>
-        <item>
           <attribute name="label" translatable="yes">_Find</attribute>
           <attribute name="action">win.find</attribute>
           <attribute name="accel">&lt;Primary&gt;f</attribute>
diff --git a/src/gdict-window.c b/src/gdict-window.c
index 836cc45..45baa54 100644
--- a/src/gdict-window.c
+++ b/src/gdict-window.c
@@ -158,7 +158,6 @@ static const gchar *toggle_actions[] = {
   "next-def",
   "first-def",
   "last-def",
-  "select-all",
   "find",
   "find-next",
   "find-previous",
@@ -913,21 +912,6 @@ gdict_window_cmd_file_close_window (GSimpleAction *action,
 }
 
 static void
-gdict_window_cmd_edit_select_all (GSimpleAction *action,
-                                  GVariant      *parameter,
-                                  gpointer       user_data)
-{
-  GdictWindow *window = user_data;
-
-  g_assert (GDICT_IS_WINDOW (window));
-
-  if (gtk_widget_has_focus (window->entry))
-    gtk_editable_select_region (GTK_EDITABLE (window->entry), 0, -1);
-  else
-    gdict_defbox_select_all (GDICT_DEFBOX (window->defbox));
-}
-
-static void
 gdict_window_cmd_edit_find (GSimpleAction *action,
                             GVariant      *parameter,
                             gpointer       user_data)
@@ -1151,7 +1135,6 @@ static const GActionEntry entries[] =
   { "close", gdict_window_cmd_file_close_window, NULL, NULL, NULL },
 
   /* Edit menu */
-  { "select-all", gdict_window_cmd_edit_select_all, NULL, NULL, NULL },
   { "find", gdict_window_cmd_edit_find, NULL, NULL, NULL },
   { "find-next", gdict_window_cmd_edit_find_next, NULL, NULL, NULL },
   { "find-previous", gdict_window_cmd_edit_find_previous, NULL, NULL, NULL },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]