[gnumeric] Scrollbars: fix undo problem.



commit 570b320cb4a5708b047d7845192a25f62582eee6
Author: Morten Welinder <terra gnome org>
Date:   Sat Feb 21 18:30:32 2015 -0500

    Scrollbars: fix undo problem.

 ChangeLog                 |    3 +++
 NEWS                      |    1 +
 src/commands.c            |    2 +-
 src/sheet-object-widget.c |    4 ++--
 4 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index e52c863..b3d69da 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2015-02-21  Morten Welinder  <terra gnome org>
 
+       * src/commands.c (cmd_so_set_adjustment_adj): horizontal is a
+       gboolean, not a double.
+
        * src/sheet-object-widget.c
        (sheet_widget_adjustment_write_xml_sax): Save with sufficient, not
        fixed, precision.
diff --git a/NEWS b/NEWS
index d708135..ae98c54 100644
--- a/NEWS
+++ b/NEWS
@@ -22,6 +22,7 @@ Morten:
        * Fix xlsx export of line style None.
        * Fix search-and-replace problem with text format.
        * xlsx import/export of gradients.
+       * Fix undo problems with scrollbars.
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.20
diff --git a/src/commands.c b/src/commands.c
index 2c08d7c..5fa50c5 100644
--- a/src/commands.c
+++ b/src/commands.c
@@ -7683,7 +7683,7 @@ cmd_so_set_adjustment_adj (CmdSOSetAdjustment *me)
        double old_upper = gtk_adjustment_get_upper (adj);
        double old_step = gtk_adjustment_get_step_increment (adj);
        double old_page = gtk_adjustment_get_page_increment (adj);
-       double old_horizontal;
+       gboolean old_horizontal;
        g_object_get (G_OBJECT (me->so), "horizontal", &old_horizontal, NULL);
 
        gtk_adjustment_configure (adj,
diff --git a/src/sheet-object-widget.c b/src/sheet-object-widget.c
index 60cc39c..7cebb68 100644
--- a/src/sheet-object-widget.c
+++ b/src/sheet-object-widget.c
@@ -1884,8 +1884,8 @@ sheet_widget_adjustment_set_details (SheetObject *so, GnmExprTop const *tlink,
 static GtkWidget *
 sheet_widget_adjustment_create_widget (G_GNUC_UNUSED SheetObjectWidget *sow)
 {
-       g_warning("ERROR: sheet_widget_adjustment_create_widget SHOULD NEVER BE CALLED (but it has been)!\n");
-       return gtk_frame_new ("invisiwidget(WARNING: I AM A BUG!)");
+       g_assert_not_reached ();
+       return NULL;
 }
 
 SOW_MAKE_TYPE (adjustment, Adjustment,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]