[easytag] Return a value from et_artist_album_list_add_file



commit 5b8659a80ece30fb7353ac68c3381d8f7d5123d0
Author: David King <amigadave amigadave com>
Date:   Sat Feb 7 09:52:59 2015 +0000

    Return a value from et_artist_album_list_add_file
    
    Use g_return_val_if_fail() rather than g_return_if_fail(), and return an
    empty list of no ET_File is supplied.
    
    Found with Coverity (CID 1268295).

 src/file_list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/file_list.c b/src/file_list.c
index 4451857..d35c21e 100644
--- a/src/file_list.c
+++ b/src/file_list.c
@@ -574,7 +574,7 @@ et_artist_album_list_add_file (GList *file_list,
     GList *result;
     ET_File *etfile = NULL;
 
-    g_return_if_fail (ETFile != NULL);
+    g_return_val_if_fail (ETFile != NULL, NULL);
 
     /* Album value of the ETFile passed in parameter. */
     ETFile_Album = ((File_Tag *)ETFile->FileTag->data)->album;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]