[meld: 41/63] filediff, meldwindow: Remove outdated comments about new save stuff
- From: Kai Willadsen <kaiw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [meld: 41/63] filediff, meldwindow: Remove outdated comments about new save stuff
- Date: Wed, 16 Dec 2015 21:22:25 +0000 (UTC)
commit e1d183f676ebcb2c3470a593c195e29cc0580fb4
Author: Kai Willadsen <kai willadsen gmail com>
Date: Sun Sep 27 10:16:45 2015 +1000
filediff, meldwindow: Remove outdated comments about new save stuff
meld/filediff.py | 3 ---
meld/meldwindow.py | 5 +----
2 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/meld/filediff.py b/meld/filediff.py
index ef448e9..46231db 100644
--- a/meld/filediff.py
+++ b/meld/filediff.py
@@ -1519,9 +1519,6 @@ class FileDiff(melddoc.MeldDoc, gnomeglade.Component):
callback=self.file_saved_cb,
user_data=(pane,)
)
- # TODO: We need to stop assuming that we know whether a save
- # has been successful at the end of this function; we won't
- # really know until later.
return True
def file_saved_cb(self, saver, result, user_data):
diff --git a/meld/meldwindow.py b/meld/meldwindow.py
index 13b865e..e1a9aba 100644
--- a/meld/meldwindow.py
+++ b/meld/meldwindow.py
@@ -302,10 +302,7 @@ class MeldWindow(gnomeglade.Component):
response = page.on_delete_event()
if response == Gtk.ResponseType.CANCEL:
should_cancel = True
- # TODO: Now also need to check whether any page is in an error
- # state, or is asynchronously closing, or... etc. Some errors
- # or cancellation requests will be returned from the page's
- # on_delete_event, but not all.
+
should_cancel = should_cancel or self.has_pages()
if should_cancel:
self.should_close = True
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]