[perl-Glib] Sort the output of podify_signals in a deterministic way.



commit b17355f247cb062b018e3d93a8beb617febc509e
Author: intrigeri <intrigeri boum org>
Date:   Sat May 2 12:45:36 2015 +0000

    Sort the output of podify_signals in a deterministic way.
    
    The output of Glib::Type->list_signals is unsorted. This results in the
    generated pod files to be in random order which makes packages using signals
    compile not reproducibly [1].
    
    It was suggested to Glib upstream [2] to sort the output of g_signal_list_ids
    but it got rejected. Thus the change has to be made here.
    
    [1] https://wiki.debian.org/ReproducibleBuilds/About
    [2] https://bugzilla.gnome.org/show_bug.cgi?id=743863
    
    Author: akira <marivalenm gmail com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748796

 lib/Glib/GenPod.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/lib/Glib/GenPod.pm b/lib/Glib/GenPod.pm
index 44656d7..63dfbf9 100644
--- a/lib/Glib/GenPod.pm
+++ b/lib/Glib/GenPod.pm
@@ -710,7 +710,7 @@ sub podify_signals {
        my @sigs = Glib::Type->list_signals (shift);
        return undef unless @sigs;
        $str = "=over\n\n";
-       foreach (@sigs) {
+       foreach (sort {$a->{signal_name} cmp $b->{signal_name} } @sigs) {
                $str .= '=item ';
                $str .= convert_type ($_->{return_type}).' = '
                        if exists $_->{return_type};


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]