[gnumeric] A better fix for #737261



commit f0fcdbfafde8439f1ead958356597259c22a7521
Author: Jean Brefort <jean brefort normalesup org>
Date:   Wed Sep 24 18:35:16 2014 +0200

    A better fix for #737261

 src/dialogs/dialog-recent.c |   30 ++++++++++++++----------------
 1 files changed, 14 insertions(+), 16 deletions(-)
---
diff --git a/src/dialogs/dialog-recent.c b/src/dialogs/dialog-recent.c
index bc42f9c..8fedb33 100644
--- a/src/dialogs/dialog-recent.c
+++ b/src/dialogs/dialog-recent.c
@@ -89,8 +89,6 @@ url_renderer_func (GtkTreeViewColumn *tree_column,
 
        gtk_tree_model_get (model, iter, RECENT_COL_INFO, &ri, -1);
 
-       if (ri == NULL)
-               return;
        uri = gtk_recent_info_get_uri (ri);
        filename = go_filename_from_uri (uri);
        if (filename) {
@@ -244,20 +242,6 @@ dialog_recent_used (WBCGtk *wbcg)
 
        dialog = GTK_DIALOG (go_gtk_builder_get_widget (gui, "recent_dialog"));
 
-       gtk_tree_view_column_set_cell_data_func
-               (GTK_TREE_VIEW_COLUMN (gtk_builder_get_object (gui, "url_column")),
-                GTK_CELL_RENDERER (gtk_builder_get_object (gui, "url_renderer")),
-                url_renderer_func,
-                NULL,
-                NULL);
-
-       gtk_tree_view_column_set_cell_data_func
-               (GTK_TREE_VIEW_COLUMN (gtk_builder_get_object (gui, "age_column")),
-                GTK_CELL_RENDERER (gtk_builder_get_object (gui, "age_renderer")),
-                age_renderer_func,
-                g_date_time_new_now_local (),
-                (GDestroyNotify)g_date_time_unref);
-
        g_signal_connect (G_OBJECT (dialog), "response",
                          G_CALLBACK (cb_response), wbcg);
 
@@ -286,6 +270,20 @@ dialog_recent_used (WBCGtk *wbcg)
 
        populate_recent_model (gui);
 
+       gtk_tree_view_column_set_cell_data_func
+               (GTK_TREE_VIEW_COLUMN (gtk_builder_get_object (gui, "url_column")),
+                GTK_CELL_RENDERER (gtk_builder_get_object (gui, "url_renderer")),
+                url_renderer_func,
+                NULL,
+                NULL);
+
+       gtk_tree_view_column_set_cell_data_func
+               (GTK_TREE_VIEW_COLUMN (gtk_builder_get_object (gui, "age_column")),
+                GTK_CELL_RENDERER (gtk_builder_get_object (gui, "age_renderer")),
+                age_renderer_func,
+                g_date_time_new_now_local (),
+                (GDestroyNotify)g_date_time_unref);
+
        /* ---------------------------------------- */
 
        g_object_set_data_full (G_OBJECT (dialog), "gui", gui, g_object_unref);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]