[gnome-builder] code-assist: disable service if we fail a parse call.



commit 33513c4c72ee135e1000be39d43a771c8c5315cd
Author: Christian Hergert <christian hergert me>
Date:   Thu Nov 20 22:54:37 2014 -0800

    code-assist: disable service if we fail a parse call.
    
    This should stop some spurious warnings. All this needs to be redesigned
    anyway.

 src/editor/gb-editor-code-assistant.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/src/editor/gb-editor-code-assistant.c b/src/editor/gb-editor-code-assistant.c
index 87837fa..b19e83a 100644
--- a/src/editor/gb-editor-code-assistant.c
+++ b/src/editor/gb-editor-code-assistant.c
@@ -247,6 +247,7 @@ gb_editor_code_assistant_parse_cb (GObject      *source_object,
   if (!gca_service_call_parse_finish (service, &document_path, result, &error))
     {
       g_warning ("%s", error->message);
+      gb_editor_code_assistant_destroy (tab);
       g_clear_error (&error);
       GOTO (cleanup);
     }
@@ -585,6 +586,9 @@ setup_service_proxy (GbEditorTab *tab,
   GbEditorTabPrivate *priv = tab->priv;
   gint width;
 
+  g_assert (GB_IS_EDITOR_TAB (tab));
+  g_assert (GCA_IS_SERVICE (service));
+
   ENTRY;
 
   priv->gca_service = g_object_ref (service);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]