[gdm] transient-display: don't call unmanage from finish



commit 5a96e7f97dcc33d5dbca71652994183eeef0df4f
Author: Ray Strode <rstrode redhat com>
Date:   Fri May 16 09:38:08 2014 -0400

    transient-display: don't call unmanage from finish
    
    GdmTransientDisplay has this code:
    
            /* we don't restart/remanage transient displays */
            gdm_display_unmanage (display);
    
    But the display factory already makes sure transient displays aren't
    restarted. Furthermore, calling unmanage from finish changes the status
    of the display to UNMANAGED instead of FINISHED which causes an
    assertion to get blown when the display is disposed if the user logouts
    out when user switching.
    
    This commit removes the code since it's unnecessary and actively
    harmful.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728488

 daemon/gdm-transient-display.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/daemon/gdm-transient-display.c b/daemon/gdm-transient-display.c
index c873688..661256e 100644
--- a/daemon/gdm-transient-display.c
+++ b/daemon/gdm-transient-display.c
@@ -98,9 +98,6 @@ gdm_transient_display_finish (GdmDisplay *display)
 
         GDM_DISPLAY_CLASS (gdm_transient_display_parent_class)->finish (display);
 
-        /* we don't restart/remanage transient displays */
-        gdm_display_unmanage (display);
-
         return TRUE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]