[dia] [warningectomy] '&&' within '||'
- From: Hans Breuer <hans src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dia] [warningectomy] '&&' within '||'
- Date: Sun, 8 Jun 2014 09:01:34 +0000 (UTC)
commit e5f0051dbee91ec85271ff66b597f0ab76571a58
Author: Hans Breuer <hans breuer org>
Date: Fri Jun 6 13:56:24 2014 +0200
[warningectomy] '&&' within '||'
diapathrenderer.c(124,16) : warning: '&&' within '||' [-Wlogical-op-parentheses]
if ( stroke && self->last_op == PATH_FILL
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diapathrenderer.c(124,16) : note: place parentheses around the '&&' expression to silence this warning
if ( stroke && self->last_op == PATH_FILL
^
( )
diapathrenderer.c(125,14) : warning: '&&' within '||' [-Wlogical-op-parentheses]
|| fill && self->last_op == PATH_STROKE)
~~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diapathrenderer.c(125,14) : note: place parentheses around the '&&' expression to silence this warning
|| fill && self->last_op == PATH_STROKE)
^
( )
lib/diapathrenderer.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/lib/diapathrenderer.c b/lib/diapathrenderer.c
index 7d700af..271bb18 100644
--- a/lib/diapathrenderer.c
+++ b/lib/diapathrenderer.c
@@ -121,8 +121,8 @@ _get_current_path (DiaPathRenderer *self,
new_path = TRUE;
}
/* also create a new path if the last op was a fill and we now stroke */
- if ( stroke && self->last_op == PATH_FILL
- || fill && self->last_op == PATH_STROKE)
+ if ( (stroke && self->last_op == PATH_FILL)
+ || (fill && self->last_op == PATH_STROKE))
new_path = TRUE;
self->last_op = stroke ? PATH_STROKE : PATH_FILL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]