[dia] [warningectomy] & has lower precedence than ==
- From: Hans Breuer <hans src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dia] [warningectomy] & has lower precedence than ==
- Date: Sun, 8 Jun 2014 09:01:29 +0000 (UTC)
commit 24f146b8150e3310a443be540f2b5a2c88ac5493
Author: Hans Breuer <hans breuer org>
Date: Fri Jun 6 13:52:37 2014 +0200
[warningectomy] & has lower precedence than ==
propdialogs.c(211,48) : warning: & has lower precedence than ==; == will be evaluated first
[-Wparentheses]
gboolean was_set = (pwa->prop->experience & PXP_NOTSET == 0);
^~~~~~~~~~~~~~~~~
propdialogs.c(211,48) : note: place parentheses around the '==' expression to silence this warning
gboolean was_set = (pwa->prop->experience & PXP_NOTSET == 0);
^ ~~~~~~~~~~~~~~~
propdialogs.c(211,48) : note: place parentheses around the & expression to evaluate it first
gboolean was_set = (pwa->prop->experience & PXP_NOTSET == 0);
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
lib/propdialogs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/lib/propdialogs.c b/lib/propdialogs.c
index 3c0a208..b685675 100644
--- a/lib/propdialogs.c
+++ b/lib/propdialogs.c
@@ -208,7 +208,7 @@ property_signal_handler(GObject *obj,
*
* See also commonprop_reset_widget() for more information
*/
- gboolean was_set = (pwa->prop->experience & PXP_NOTSET == 0);
+ gboolean was_set = ((pwa->prop->experience & PXP_NOTSET) == 0);
pwa->prop->ops->reset_widget(pwa->prop,pwa->widget);
if (was_set)
pwa->prop->experience &= ~PXP_NOTSET;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]