[gnumeric] Add warning dialog. [#733352]



commit e9842dda75e8a1552ef132486768b53550202653
Author: Andreas J. Guelzow <aguelzow pyrshep ca>
Date:   Tue Jul 29 10:30:52 2014 -0600

    Add warning dialog. [#733352]
    
    2014-07-29  Andreas J. Guelzow <aguelzow pyrshep ca>
    
        * dialog-cell-format-cond.c (cb_c_fmt_dialog_dialog_buttons):
        ask user if it looks they may have forgotten to add a cond.
        format

 NEWS                                  |    1 +
 src/dialogs/ChangeLog                 |    6 ++++++
 src/dialogs/dialog-cell-format-cond.c |    6 ++++++
 3 files changed, 13 insertions(+), 0 deletions(-)
---
diff --git a/NEWS b/NEWS
index 0e2fa2d..d0b77c2 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,7 @@ Gnumeric 1.12.18
 
 Andreas:
        * Improve documentation. [#733466]
+       * Add warning dialog. [#733352]
 
 Morten:
        * Fix xls export problem.  [#733771]
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index 395d1b9..dc14c32 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,3 +1,9 @@
+2014-07-29  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+       * dialog-cell-format-cond.c (cb_c_fmt_dialog_dialog_buttons):
+       ask user if it looks they may have forgotten to add a cond.
+       format
+
 2014-06-09  Morten Welinder <terra gnome org>
 
        * Release 1.12.17
diff --git a/src/dialogs/dialog-cell-format-cond.c b/src/dialogs/dialog-cell-format-cond.c
index 2461a90..eedbd9f 100644
--- a/src/dialogs/dialog-cell-format-cond.c
+++ b/src/dialogs/dialog-cell-format-cond.c
@@ -115,6 +115,12 @@ static void c_fmt_dialog_apply_add_choice (CFormatState *state, GnmStyleCond *co
 static void
 cb_c_fmt_dialog_dialog_buttons (G_GNUC_UNUSED GtkWidget *btn, CFormatState *state)
 {
+       /* users may accidentally click on 'close' before adding the formatting style see #733352 */
+       if (!gtk_widget_get_sensitive (GTK_WIDGET (state->editor.add_button)) ||
+           gtk_widget_get_sensitive (GTK_WIDGET (state->clear)) ||
+           go_gtk_query_yes_no (GTK_WINDOW (state->dialog), FALSE, 
+                                _("You did not add the defined conditional format."
+                                  " Do you really want to close the conditional formatting dialog?")))
                gtk_widget_destroy (GTK_WIDGET (state->dialog));
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]