[goffice] Always save an axis position. [#722402]



commit a1f574586975ddfc42f26a554f1b13ad0ae58e56
Author: Jean Brefort <jean brefort normalesup org>
Date:   Fri Jan 17 14:40:13 2014 +0100

    Always save an axis position. [#722402]

 ChangeLog                     |    5 +++++
 NEWS                          |    1 +
 goffice/graph/gog-axis-line.c |    6 +++++-
 3 files changed, 11 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 0de5e41..0c9b0e6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-01-17  Jean Brefort  <jean brefort normalesup org>
+
+       * goffice/graph/gog-axis-line.c (gog_axis_base_set_property),
+       (gog_axis_base_class_init): always save the axis position. [#722402]
+
 2014-01-06  Jean Brefort  <jean brefort normalesup org>
 
        * goffice/canvas/goc-graph.c (goc_graph_do_tooltip): fix compiler warning.
diff --git a/NEWS b/NEWS
index 9935080..b0c087a 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@ Jean
        * Fix graph guru appearance when used with gtk+-3.10. [#719681]
        * Fix crasher in box plots. [#720310]
        * Fix elements number in polar plot series. [#720355]
+       * Always save an axis position. [#722402]
 
 Morten:
        * Improve complex math, notably complex power.
diff --git a/goffice/graph/gog-axis-line.c b/goffice/graph/gog-axis-line.c
index 1f5ff60..1a92269 100644
--- a/goffice/graph/gog-axis-line.c
+++ b/goffice/graph/gog-axis-line.c
@@ -95,6 +95,9 @@ gog_axis_base_set_property (GObject *obj, guint param_id,
                                position = GOG_AXIS_CROSS;
                        else if (!g_ascii_strcasecmp (str, "high"))
                                position = GOG_AXIS_AT_HIGH;
+                       else if (!g_ascii_strcasecmp (str, "auto"))
+                               /* this should not occur, but it is the default */
+                               position = GOG_AXIS_AUTO;
                        else {
                                g_warning ("[GogAxisBase::set_property] invalid axis position (%s)", str);
                                return;
@@ -681,7 +684,8 @@ gog_axis_base_class_init (GObjectClass *gobject_klass)
                g_param_spec_string ("pos-str",
                        _("Axis position (as a string)"),
                        _("Where to position an axis low, high, or crossing"),
-                       "low",
+                       "auto", /*the default will never occur, we need that to avoid axis
+                   loose their "low" position on serialization, see #722402. */
                        GSF_PARAM_STATIC | G_PARAM_READWRITE | GO_PARAM_PERSISTENT));
        g_object_class_install_property (gobject_klass, AXIS_BASE_PROP_MAJOR_TICK_LABELED,
                g_param_spec_boolean ("major-tick-labeled",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]