[gtk+] popover: Clamp tail gap limits by the tail height on that side
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] popover: Clamp tail gap limits by the tail height on that side
- Date: Sat, 13 Dec 2014 17:07:27 +0000 (UTC)
commit ba22ae8cceb8d74bf50742d94cc887e15e4f232e
Author: Carlos Garnacho <carlosg gnome org>
Date: Sat Dec 13 18:02:29 2014 +0100
popover: Clamp tail gap limits by the tail height on that side
All popover sides have extra margins to possibly hold the tail, this is
accounted for in gtk_popover_get_rect_coords(), and should be accounted
for too in the tail position calculation.
This fixes the gtk_render_frame_gap() warnings seen when a popover is
pushed far too close to window sides.
gtk/gtkpopover.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c
index a3a1902..8627ca8 100644
--- a/gtk/gtkpopover.c
+++ b/gtk/gtkpopover.c
@@ -568,16 +568,16 @@ gtk_popover_get_gap_coords (GtkPopover *popover,
{
tip_pos = rect.x + (rect.width / 2);
initial_x = CLAMP (tip_pos - TAIL_GAP_WIDTH / 2,
- border_radius + margin.left,
- allocation.width - TAIL_GAP_WIDTH - margin.right - border_radius);
+ border_radius + margin.left + TAIL_HEIGHT,
+ allocation.width - TAIL_GAP_WIDTH - margin.right - border_radius - TAIL_HEIGHT);
initial_y = base;
tip_x = CLAMP (tip_pos, 0, allocation.width);
tip_y = tip;
final_x = CLAMP (tip_pos + TAIL_GAP_WIDTH / 2,
- border_radius + margin.left + TAIL_GAP_WIDTH,
- allocation.width - margin.right - border_radius);
+ border_radius + margin.left + TAIL_GAP_WIDTH + TAIL_HEIGHT,
+ allocation.width - margin.right - border_radius - TAIL_HEIGHT);
final_y = base;
}
else
@@ -586,16 +586,16 @@ gtk_popover_get_gap_coords (GtkPopover *popover,
initial_x = base;
initial_y = CLAMP (tip_pos - TAIL_GAP_WIDTH / 2,
- border_radius + margin.top,
- allocation.height - TAIL_GAP_WIDTH - margin.bottom - border_radius);
+ border_radius + margin.top + TAIL_HEIGHT,
+ allocation.height - TAIL_GAP_WIDTH - margin.bottom - border_radius - TAIL_HEIGHT);
tip_x = tip;
tip_y = CLAMP (tip_pos, 0, allocation.height);
final_x = base;
final_y = CLAMP (tip_pos + TAIL_GAP_WIDTH / 2,
- border_radius + margin.top + TAIL_GAP_WIDTH,
- allocation.height - margin.right - border_radius);
+ border_radius + margin.top + TAIL_GAP_WIDTH + TAIL_HEIGHT,
+ allocation.height - margin.right - border_radius - TAIL_HEIGHT);
}
if (initial_x_out)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]