[gnumeric] SheetControlGUI: improve unant.



commit c3cb60af0fbf9436aeb5755dcbd21ddab57ef635
Author: Morten Welinder <terra gnome org>
Date:   Sat Dec 6 15:03:30 2014 -0500

    SheetControlGUI: improve unant.
    
    While not actually observed as a problem, make sure that we destroy
    the GocItem used for anting.

 ChangeLog               |    4 ++++
 src/sheet-control-gui.c |    6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 7f875e2..48cbabf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2014-12-06  Morten Welinder  <terra gnome org>
 
+       * src/sheet-control-gui.c (scg_unant): Destroy item cursors.  We
+       want them visually gone and g_object_unref does not guarantee
+       that.
+
        * src/sheet.c (sheet_insert_rows, sheet_insert_cols): Clear style
        dependents.  A later step clears and re-applies style completely
        for the moved area.  Fixes #741197.
diff --git a/src/sheet-control-gui.c b/src/sheet-control-gui.c
index 39f424d..ae48e2d 100644
--- a/src/sheet-control-gui.c
+++ b/src/sheet-control-gui.c
@@ -1850,8 +1850,10 @@ scg_unant (SheetControl *sc)
        SCG_FOREACH_PANE (scg, pane, {
                GSList *l;
 
-               for (l = pane->cursor.animated; l; l = l->next)
-                       g_object_unref (l->data);
+               for (l = pane->cursor.animated; l; l = l->next) {
+                       GocItem *item = l->data;
+                       goc_item_destroy (l->data);
+               }
 
                g_slist_free (pane->cursor.animated);
                pane->cursor.animated = NULL;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]